Opened 3 weeks ago

Closed 6 days ago

#2659 closed enhancement (fixed)

PeerState.java: remove _concurrentMessagesActive

Reported by: jogger Owned by: zzz
Priority: minor Milestone: 0.9.44
Component: router/transport Version: 0.9.43
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

For all practical purposes _outboundMessages.size() has the same information.

Subtickets

Change History (2)

comment:1 Changed 7 days ago by zzz

Milestone: undecided0.9.44
Status: newaccepted

That sounds right. Looks like the field was originally an unsynced way to avoid taking the lock, but the locking has changed over the years. A separate field that's incremented and decremented seems to be problematic and error-prone.

comment:2 Changed 6 days ago by zzz

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.