Opened 16 months ago
#2664 new enhancement
PeerStata.java: Remove dead code from acked()
Reported by: | jogger | Owned by: | zzz |
---|---|---|---|
Priority: | minor | Milestone: | undecided |
Component: | router/transport | Version: | 0.9.43 |
Keywords: | Cc: | ||
Parent Tickets: | Sensitive: | no |
Description
Both acked() functions have this:
} else if (state.getPushCount() <= 0) {
That code can never strike as we push() everything we pull off _outboundQueue. Thus the functions could be much shorter and more readable.
Also the comment there is misleading like at other places as well, because there is no order in _outboundMessages since #2293. Send order is guaranteed via _outboundQueue. #2293 made code a little bit faster, but improvements of traffic metrics claimed there are near to ridiculous.
Subtickets
Note: See
TracTickets for help on using
tickets.