Opened 9 years ago

Closed 9 years ago

#273 closed defect (fixed)

Several 0.8.1 i2psnark issues

Reported by: zzz Owned by: zzz
Priority: minor Milestone: 0.8.3
Component: apps/i2psnark Version: 0.8.1
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

See http://zzz.i2p/topics/767 for more details

  • tracker info links don't work in dillo, possibly non-compliant with html standards
  • other html compliance issues
  • img alt text not consistent with folliwng text, no space between alt text and following text (e.g. DownRateRate?)
  • img tooltip duplicates following text (e.g. img tooltip says Torrent and following text says Torrent) - in this case the tooptip should be deleted
  • popup that shows full Tracker Error is gone
  • attempt to prevent line breaks is not fully successful esp. with some translations, better to handle it
  • Maybe stopped mitsubishi should be red instead of purple?
  • General comments about eyes bleeding, hard to read, etc.
  • In file manager, you renamed 'Do not download' to 'Ignore' which is confusing people

Subtickets

Change History (15)

comment:1 Changed 9 years ago by zzz

Owner: changed from dr|zed to drzed
Status: newassigned

Also the changes from

<a title=foo>bar</a>

to

<a title=foo><img title=foo>bar</a>

is incorrect, as (I don't think) the <a> title will now never be displayed, they should be removed.

comment:2 Changed 9 years ago by zzz

Version: 0.80.8.1

comment:3 Changed 9 years ago by anonymous

Dillo extracted Error report:

HTML warning: line 1, the required DOCTYPE declaration is missing (or invalid)
HTML warning: line 24, <a> is not allowed to contain <div>. — closing <a>
HTML warning: line 24, unexpected closing tag: </a> — expected </table>.
HTML warning: line 61, <span> is not allowed to contain <form>. — closing <span>
HTML warning: line 69, unexpected closing tag: </form> — expected </div>.
HTML warning: line 70, unexpected closing tag: </span> — expected </div>.
HTML warning: line 71, <span> is not allowed to contain <form>. — closing <span>
HTML warning: line 71, nested forms
HTML warning: line 82, unexpected closing tag: </span> — expected </div>.
HTML warning: line 84, unexpected closing tag: </div> — expected </form>.
HTML warning: line 84, unexpected closing tag: </div> — expected </form>.
HTML warning: line 84, unexpected closing tag: </div> — expected </form>.
HTML warning: line 84, unexpected closing tag: </center> — expected </form>.
HTML warning: line 84, unexpected closing tag: </body> — expected </form>.
HTML warning: line 84, unexpected closing tag: </html> — expected </form>.

Line 24 is a torrent line. The CSS tag div is used to declare a layout once, not multiple times - this is the case when there is more than one torrent. The html tag a may not contain a div tag and that's why dillo aborts interpreting the line and that's why the link doesn't work.

comment:4 Changed 9 years ago by zzz

Another error - you added the tooltip "Torrent file must originate from an I2P-based tracker" to the add torrent box.

This is not true, I don't know where you came up with it. A torrent file can come from anywhere. Perhaps you meant that the torrent file must contain an I2P-based announce URL. But that isn't true either. Snark will convert any non-i2p torrent to use opentrackers.

So the whole tooltip is bogus.

comment:5 Changed 9 years ago by zzz

One more.

You have icon highlighting for the stop/start/delete/remove buttons but not for stop all, start all, show peers, or hide peers icons in the table header.

comment:6 Changed 9 years ago by zzz

ok, re: "… must originate …", I stand corrected, the torrent fetcher will not route through an outproxy. So it must come from an i2p tracker _or_ any other i2p eepsite. So it must come from an i2p URL of some sort.

comment:7 Changed 9 years ago by zzz

Yeah, in particular, not having text or obvious icons to distinguish between "OK" (i.e. leeching) and "Seeding" is a big problem.

Right now, seeding is orange and leeching is green. Which seems backwards. But we really need text or at the least, much better icons than different-colored Mitsubishis.

I saw on IRC that your goal was to get rid of all text? I certainly hope not, especially given the comments in the thread on zzz.i2p.

comment:8 Changed 9 years ago by zzz

FYI the stop/start-all hover and the extra tooltip I partially fixed by during my GET→POST conversion.

The seeding vs. leeching Mitsubishis definitely need work, the more I stare at it. Please make something more obvious.

comment:9 Changed 9 years ago by zzz

Priority: minorblocker

comment:10 Changed 9 years ago by zzz

Owner: changed from drzed to zzz

comment:11 Changed 9 years ago by zzz

Resolution: fixed
Status: assignedclosed

All fixed in 0.8.1-36-rc

comment:12 Changed 9 years ago by DISABLED

Resolution: fixed
Status: closedreopened

Having issues with all versions of GNU IceCat? (modified Mozilla Firefox by GNU) and i2psnark:

  • 0,5 sec freeze when I switch back to tab with i2psnark (default theme)
  • This issue also affect me with default I2P Router console theme. I switched to 'Classic' theme and it gone. Maybe implement 'Classic' theme in i2psnark too?

comment:13 Changed 9 years ago by zzz

Milestone: 0.8.20.8.3
Priority: blockerminor

How many torrents on the page? Does more torrents make it worse?
Does it always happen or only sometimes?
Maybe it's related to the background images rendering slowly?
Never heard of IceCat?.

comment:14 in reply to:  13 Changed 9 years ago by DISABLED

Replying to zzz:

How many torrents on the page? Does more torrents make it worse?

No, it does not depend on the number of torrents. Without any torrents it freezes for 0,5 sec, and with 10-20 same.

Does it always happen or only sometimes?

Always.

Maybe it's related to the background images rendering slowly?

Not, I think it is issue in css styles or something related to it.
I had this issue with router console too. I switched themes, and it gone. But in i2psnark I don't see theme switcher :(

Never heard of IceCat?.

http://www.gnu.org/software/gnuzilla/, this is fork of Mozilla Firefox made by GNU.

comment:15 Changed 9 years ago by zzz

Resolution: fixed
Status: reopenedclosed

0.8.3 contains fixes so repeated image and css fixes return 304 not modified, this speeds things up considerably.

Note: See TracTickets for help on using tickets.