Opened 2 weeks ago

Last modified 2 weeks ago

#2794 new defect

Prevent message ID 0

Reported by: jogger Owned by:
Priority: minor Milestone: undecided
Component: router/general Version: 0.9.47
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

A valid message with ID 0 is handled incorrectly throughout the router.

How to reproduce: Follow the logs until a message with ID 0 comes along. May turn up repeatedly as not ACKed by UDPTransport.

Easiest fix is to use "while (_uniqueId ⇐ 0)" in getUniqueId(). Then also the initialization of _uniqueId can be removed.

Subtickets

Change History (1)

comment:1 Changed 2 weeks ago by zzz

I2NP spec does not prohibit ID 0.
We could follow your suggestion as a workaround, but of course old routers and other implementations would still use 0.
Real fix would be "throughout the router", do you have a list of places?

Note: See TracTickets for help on using tickets.