Opened 8 years ago

Closed 8 years ago

#393 closed defect (fixed)

Remove documentation files from BOB.jar

Reported by: zzz Owned by: sponge
Priority: minor Milestone: 0.8.4
Component: apps/BOB Version: 0.8.2
Keywords: Cc: killyourtv@…
Parent Tickets: Sensitive: no

Description

Please remove license-WTFPL.txt and package.html files from the jar. Licenses should be in the licenses/ directory, not in the jars. And this appears to be identical to licenses/COPYING-BOB.txt.
The package.html file is for javadoc and should not be in the jar.

Subtickets

Change History (4)

comment:1 Changed 8 years ago by sponge

Actually doing such things is pretty common… jar file containing javadocs can be handy. However I do understand that we need to chop away at any bloat for updates, I'm on it.

comment:2 Changed 8 years ago by sponge

Status: newaccepted

comment:3 Changed 8 years ago by killyourtv

Cc: killyourtv@… added

If the following would be the correct way of doing it, I can check it in.

--- apps/BOB/nbproject/project.properties       d50fd2220134892d3bdb85be562e77bed38425af
+++ apps/BOB/nbproject/project.properties       93ae0ea83e9c94f017d8ae508d96156110591520
@@ -26,7 +26,7 @@ endorsed.classpath=
 dist.jar=${dist.dir}/BOB.jar
 dist.javadoc.dir=${dist.dir}/javadoc
 endorsed.classpath=
-excludes=
+excludes=**/license-WTFPL.txt, **/package.html
 file.reference.build-javadoc=../../i2p.i2p/build/javadoc
 file.reference.i2p.jar=../../core/java/build/i2p.jar
 file.reference.i2ptunnel.jar=../i2ptunnel/java/build/i2ptunnel.jar

I have verified that neither license-WTFPL.txt nor package.html will be in the .jar, and that the javadocs contents remain the same.

comment:4 Changed 8 years ago by sponge

Resolution: fixed
Status: acceptedclosed

Fixed it, and any future html file will be zapped. The license file stays.

Note: See TracTickets for help on using tickets.