Opened 8 years ago

Closed 6 years ago

#546 closed defect (fixed)

Error in the ntcp reader

Reported by: slow Owned by: zzz
Priority: minor Milestone: 0.9.8
Component: router/transport Version: 0.8.10
Keywords: NTCP Cc:
Parent Tickets: Sensitive: no

Description

0.8.10-2

xxx AM CRIT [P reader 2/4] p.router.transport.ntcp.Reader: Error in the ntcp reader
     java.lang.RuntimeException: connection was not established, yet the establish state is null for NTCP Connection to kzLKYB inbound? false established? false created 139ms ago
     at net.i2p.router.transport.ntcp.Reader.processRead(Reader.java:134)
     at net.i2p.router.transport.ntcp.Reader.access$400(Reader.java:17)
     at net.i2p.router.transport.ntcp.Reader$Runner.run(Reader.java:107)
     at java.lang.Thread.run(Thread.java:619)
     at net.i2p.util.I2PThread.run(I2PThread.java:85)

Subtickets

Change History (4)

comment:1 Changed 8 years ago by zzz

Component: unspecifiedrouter/transport
Milestone: 0.8.12
Owner: set to zzz

<welterde> zzz2: hmm.. regarding #546.. seems to be running Reader before having called NTCPConnection#prepareNextWriteFast
<welterde> I think the establish-state should be created in NTCPConnection#outboundConnected as it will always fail if the remote peer is fast enough to send something before you decide to send something
<welterde> (or alternatively move the subscription of OP_READ to prepareNextWriteFast)
<zzz2> welterde, please put that info into the ticket and I'll look at it later

never mind, I'll do it.

comment:2 Changed 6 years ago by str4d

Milestone: 0.8.120.9.9

comment:3 Changed 6 years ago by str4d

Keywords: NTCP added

comment:4 Changed 6 years ago by zzz

Milestone: 0.9.90.9.8
Resolution: fixed
Status: newclosed

Pretty sure this was fixed by locking / final / refactoring in a release earlier this year. zab did a lot of it.

Possibly related: #972

Note: See TracTickets for help on using tickets.