Opened 8 years ago

Closed 8 years ago

#562 closed defect (fixed)

eepget mangles filenames

Reported by: killyourtv Owned by:
Priority: minor Milestone: 0.8.12
Component: api/utils Version: 0.8.11
Keywords: eepget Cc:
Parent Tickets: Sensitive: no

Description

When downloading with eepget, any hyphens in the filename are changed to underscores.

e.g.

$ eepget http://aululz24ugumppq56jsaw3d7mkbmcgo7dl2lgeanvpniyk2cbrda.b32.i2p/tahoe-lafs/patches/foolscap-i2p-0.6.2-r0.patch
###
== Wed Dec 07 11:42:50 UTC 2011
== Transfer of http://aululz24ugumppq56jsaw3d7mkbmcgo7dl2lgeanvpniyk2cbrda.b32.i2p/tahoe-lafs/patches/foolscap-i2p-0.6.2-r0.patch completed with 3921 bytes transferred
== Output saved to foolscap_i2p_0.6.2_r0.patch (3921 bytes)
== Transfer time: 420ms
== ETag: "11fb83-f51-4b12b4255a7c2"
== Transfer rate: 009,12KBps

Subtickets

Change History (2)

comment:1 Changed 8 years ago by zzz

Component: unspecified → api/utils

Yeah, eepget has a quite restrictive whitelist of file name characters. A better implementation is in Storage.java in i2psnark - a blacklist based on a close reading of Microsoft docs, etc.

Would be a good starter project for somebody to update eepget to do what snark does.

comment:2 Changed 8 years ago by killyourtv

Resolution: → fixed
Status: new → closed

Fixed in revision e2c0792f80bc58c67899541b6af5f5f3670725e2. Thanks for the pointer, zzz. :)

Note: See TracTickets for help on using tickets.