Opened 7 years ago

Closed 7 years ago

#570 closed defect (fixed)

reported "torrent created" after it was deleted

Reported by: guest Owned by: zzz
Priority: minor Milestone: 0.9.3
Component: apps/i2psnark Version: 0.8.11
Keywords: Cc:
Parent Tickets:

Description

I tried to create a new torrent that has 550 audio tracks. Snark didn't like it.

Many I2P trackers require you to register new torrents before seeding - please do so before starting "Grieg Edition"
Torrent created for "Grieg Edition": /var/lib/i2p/i2p-config/i2psnark/Grieg Edition.torrent
Too many files in "Grieg Edition" (550), deleting it!

There is at least one bug here, maybe two.
1) 550 files are too many files in a torrent?
2) It said the torrent was created after it said it deleted it.

Subtickets

Change History (2)

comment:1 Changed 7 years ago by zzz

  • Milestone changed from 0.8.12 to 0.8.13
  • Status changed from new to accepted

postman's tracker and i2psnark have several sanity limits, the max files is 512 in both.

you could argue it should be more. but one problem with lots of files is that people run out of file descriptors and things start failing.

If you do think 512 is too low you should file a ticket on postman's tracker too.

snark does a decent but not great job of minimizing the number of open files. It's not smart enough to start closing files when it runs out of FD's though.

I'll take a look at why it claimed it was created successfully, probably some problem with not propagating the error correctly.

comment:2 Changed 7 years ago by zzz

  • Milestone changed from 0.8.13 to 0.9.3
  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in 0.9.3. Limits are now checked during torrent creation and an error message is displayed.

Note: See TracTickets for help on using tickets.