Opened 8 years ago

Closed 3 years ago

#622 closed enhancement (wontfix)

All Icons should be flexible to style.

Reported by: DISABLED Owned by: str4d
Priority: maintenance Milestone:
Component: apps/i2psnark Version: 0.8.13
Keywords: icons css Cc:
Parent Tickets: Sensitive: no

Description

Currently, some icons are below /i2psnark/.icons/
It would be advantageous, imo, if the icons could be adapted to the respective CSS style.

E.g. (I2PSnarkServlet.java at 2182):

 -- src=\"/i2psnark/.icons/" + icon + ".png\"
 ++ src=\"" + _imgPath + icon + ".png\"

but that's not that simple (for me).

Would be nice if that could be included on occasion.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by zzz

I assumed nobody was developing new snark themes. Are you?

comment:2 in reply to:  1 Changed 8 years ago by DISABLED

Replying to zzz:

Nicht direkt, ich bin kein guter Designer. Ich benutze nach wie vor „Metall“ und habe es an meine Bedürfnisse sowie den leicht veränderten technischen Bedingungen, die neuere Versionen von I2P mit bringen, angepasst.

Sollte aber jemand ein eigenes Thema entwerfen wollen, das womöglich der Allgemeinheit zugute kommt, dann doch bitte in einem Umfeld, welches ein vollständiges «Corporate Design» ermöglicht.

The possibility of the complete «corporate cesign» is my concern.

comment:3 Changed 8 years ago by DISABLED

Ein weiterer Vorschlag / A further proposal

Es hat mich schon immer ein wenig genervt, keinen exponierten Knopf auf in der Oberfläche von I2PSnark zu haben, mit dem ich zur Router-Konsole gelange. Ich habe das wie folgt gelöst (I2PSnarkServlet.java, 245 ff.):

It had always a little annoyed me to have no exposed link at the surface of I2PSnark, with which I'm comfortably go to the console. I have achieved as follows (I2PSnarkServlet.java, 245 ff.):

        if (isConfigure) {
            out.write("<div class=\"snarknavbar\"><a href=\"/i2psnark/\" title=\"");
            out.write(_("Torrents"));
            out.write("\" class=\"snarkRefresh\">");
            out.write("<img alt=\"\" border=\"0\" src=\"" + _imgPath + "arrow_refresh.png\">&nbsp;&nbsp;");
            out.write(_("I2PSnark"));
            out.write("</a> <a href=\"http://127.0.0.1:7657/\" class=\"snarkRefresh\" target=\"_blank\">");
            out.write(_("Router Console"));
            out.write("</a>\n");

        } else {
            out.write("<div class=\"snarknavbar\">");

            out.write("<a href=\"http://127.0.0.1:7657/" + peerString + "\" title=\"");
            out.write(_("I2P Router Console"));
            out.write("\" class=\"snarkRefresh\" target=\"_blank\">");
            out.write("<img alt=\"\" border=\"0\" height=\"20\" align=\"top\" src=\"/themes/console/images/itoopie_xsm.png\">&nbsp;&nbsp;");
            out.write(_("Console"));
            out.write("</a> ");

            out.write("<a href=\"/i2psnark/\" + peerString + \" title=\"");
            out.write(_("Refresh page"));
            out.write("\" class=\"snarkRefresh\">");
            out.write("<img alt=\"\" border=\"0\" src=\"" + _imgPath + "arrow_refresh.png\">&nbsp;&nbsp;");
            out.write(_("I2PSnark"));

Das funktioniert aber nur dann optisch einwandfrei, wenn z.B. in der jeweiligen CSS die Breite der .snarknavbar angepasst wird.

But this works only then optically correct, if e.g. in the respective CSS the width: of the .snarknavbar is adjusted.

Diese Lösung ist natürlich nicht für die Zukunft gedacht. Eventuell ist ein Menu zum Ausklappen auf Dauer besser geeignet?

This solution is of course not intended for the future. Maybe a folded menu is better suited in the long run?

Also, falls es dir zusagt und du gerade nicht besseres zu Tun hast … ;)

So, if it suits you and you just do not have to do better… ;)

comment:4 Changed 8 years ago by zzz

google translate of first response:

Not directly, I'm not a good designer. I still use "metal" and I bring it to my needs as well as the slightly different technical conditions, the newer versions of I2P with adjusted.

But if someone want to create a separate topic that might benefit the general public, but please be in an environment which is a complete "corporate design" allows.

comment:5 Changed 7 years ago by str4d

Owner: changed from zzz to str4d
Status: newaccepted

I2PSnark icons were moved to the general themes directory in [b256b9b8bc3d4b7e1094b9dac6db3a329b7e6bae] in branch i2p.i2p.str4d.fux, and will appear in trunk whenever the next propagation occurs.

comment:6 Changed 7 years ago by str4d

This makes it easier to access/change the icons, but still doesn't enable per-theme icons. Having a default icon set is better than duplicating the same icons across the existing themes, so maybe the toImg method should have logic that checks if an icon exists in the theme dir, and fall back to the general dir if not.

comment:7 Changed 3 years ago by zzz

Resolution: wontfix
Status: acceptedclosed

not going to happen, not worth the trouble imho

Note: See TracTickets for help on using tickets.