Opened 7 years ago

Last modified 4 years ago

#655 open defect

Move log calls out of synch blocks where possible

Reported by: zzz Owned by:
Priority: maintenance Milestone:
Component: other Version: 0.9
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

Log.error(), warn, etc. may block under extreme logging pressure; when called while holding a lock it may slow down, lock up, or deadlock the whole router.

Go through the whole codebase and move these outside of locks, or comment out, where possible and appropriate.

As mentioned by zb at http://zzz.i2p/topics/1195?page=1#p4960

Subtickets

Change History (3)

comment:1 Changed 7 years ago by Zlatin Balevsky

Just to clarify, the referenced post identifies one possible cause of high logging pressure, even though that specific log.warn statement is outside of a lock.

This is a great change either way! +1

comment:2 Changed 7 years ago by str4d

Milestone: 0.9.3

comment:3 Changed 4 years ago by str4d

Status: newopen
Note: See TracTickets for help on using tickets.