Opened 8 years ago
Closed 7 years ago
#688 closed enhancement (fixed)
false "add to local addressbook" link in server settings
Reported by: | pqbit | Owned by: | zzz |
---|---|---|---|
Priority: | minor | Milestone: | 0.9.13 |
Component: | apps/i2ptunnel | Version: | 0.9.1 |
Keywords: | Cc: | Meeh | |
Parent Tickets: | Sensitive: | no |
Description
The link is http://localhost:7657/susidns/addressbook.jsp?book=private&hostname=i2p%20webserver, but should contain the hostname (Website name): http://localhost:7657/susidns/addressbook.jsp?book=private&hostname=my-hostname.i2p, because hostnames are added to the private addressbook and not the link name for the router console.
Subtickets
Change History (5)
comment:1 Changed 8 years ago by
Type: | defect → enhancement |
---|
comment:2 Changed 8 years ago by
Cc: | Meeh added |
---|
If I not misunderstood you, this should fix it.
In file "apps/i2ptunnel/jsp/WEB-INF/classes/net/i2p/i2ptunnel/jsp/editServer_jsp.java"
--- editServer_jsp.java.old 2012-08-11 02:18:09.863060660 +0200 +++ editServer_jsp.java 2012-09-05 06:41:50.961178732 +0200 @@ -231,9 +231,9 @@ out.write("(<span class=\"accessKey\">L</span>):\n </label>\n <textarea rows=\"1\" style=\"height: 3em;\" cols=\"60\" readonly=\"readonly\" id=\"localDestination\" title=\"Read Only: Local Destination (if known)\" wrap=\"off\" spellcheck=\"false\">"); out.print(editBean.getDestinationBase64(curTunnel)); out.write("</textarea> \n "); - if (!"".equals(editBean.getDestinationBase64(curTunnel))) { + if (!"".equals(editBean.getDestinationBase64(curTunnel))&&!"".equals(editBean.getSpoofedHost(curTunnel))) { out.write("<a href=\"/susidns/addressbook.jsp?book=private&hostname="); - out.print(editBean.getTunnelName(curTunnel)); + out.print(editBean.getSpoofedHost(curTunnel)); out.write("&destination="); out.print(editBean.getDestinationBase64(curTunnel)); out.write("#add\">");
comment:3 Changed 8 years ago by
Milestone: | 0.9.2 |
---|
comment:4 Changed 7 years ago by
Milestone: | → 0.9.13 |
---|---|
Owner: | set to zzz |
Status: | new → accepted |
Thanks kytv/meeh, I understand the OP now
I propose to modify meeh's patch to use the spoofed host if it is defined, otherwise use the tunnel name.
Yes, the tunnel name isn't always acceptable (may not end in .i2p. may have spaces, etc.) but the user has a chance to edit it before saving.
comment:5 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Fixed in dbdb65092cd42b348751cd37ea36dedef96b2004 0.9.12-2
I wouldn't classify this as a bug.
I've always considered 'add to local addressbook' to be a 'convenience' option to carry-over the base64 key…