Opened 6 years ago

Closed 6 years ago

#900 closed enhancement (fixed)

Router console in IE10

Reported by: guest Owned by: killyourtv
Priority: minor Milestone: 0.9.7
Component: apps/console Version: 0.9.4
Keywords: themes Cc:
Parent Tickets:

Description

Theme support in the router console is currently disabled for all Internet Explorer versions. However, I can't find any rendering bugs in IE10 when switching user agent to force themes. I propose adding detection of IE versions >= 10 and enable theme support in the console.

Subtickets

Change History (11)

comment:1 Changed 6 years ago by guest

Just wanted to add that all IE versions render the console in Quirks mode which means web standard support is equivalent to that of IE5. Things could probably improved for older versions too by enabling standard mode.

comment:2 Changed 6 years ago by guest

Looks like Quirks mode gets enabled because the doctype declaration has no DTD specified. This triggers standards mode for me:
<!DOCTYPE HTML PUBLIC "-W3CDTD HTML 4.01 TransitionalEN" "http://www.w3.org/TR/html4/loose.dtd">

comment:3 Changed 6 years ago by killyourtv

When I tested a few months ago, neither IE 8 and IE 9 couldn't handle the standard themes.

I can confirm that IE 10 _does_ support them BUT the user agent sent by IE10 (10.0.9200.16521) isn't going to help.

"Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Trident/6.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C)"

WTF?

...and if I'm not mistaken, IE 10 does not support conditional comments. Maybe some JS trickery could be done to allow IE10 to use normal themes.

comment:4 Changed 6 years ago by killyourtv

Also, I tested without changing the UA but temporarily disabling the check with http://pastethis.i2p/show/vbwbAuoqeWb4xMZxss6r/. The doctype was sent by the router console.

I was able to reconfirm that IE9 does not work properly with the standard themes.

comment:5 Changed 6 years ago by zzz

  • Milestone changed from 0.9.5 to 0.9.6

comment:7 Changed 6 years ago by zzz

@kytv Your pastethis link doesn't show any change to CSSHelper.java, where it actually does the forcing. that would require a similar change to that in configui.jsp. Either you forgot to include that in the diff, or else I don't understand how you were viewing the different themes.

If we can't leave the ieshim.css in for IE10, that will take a little more work to deal with that conditionally.

@OP re: DTD, interesting, we'll have to research whether we're doing the doctype wrong.

comment:8 Changed 6 years ago by zzz

  • Owner set to killyourtv
  • Status changed from new to assigned

See also #628

comment:9 Changed 6 years ago by str4d

  • Keywords themes added

comment:10 Changed 6 years ago by killyourtv

  • Milestone changed from 0.9.6 to 0.9.7
  • Status changed from assigned to accepted

I didn't have enough time to get this into 0.9.6. I'll be able to work on it early in the 0.9.7 cycle.

comment:11 Changed 6 years ago by killyourtv

  • Resolution set to fixed
  • Status changed from accepted to closed

Will be in 0.9.6-2.

Note: See TracTickets for help on using tickets.