Opened 8 years ago

Closed 8 years ago

#901 closed enhancement (wontfix)

Reject tunnels on Update

Reported by: DISABLED Owned by:
Priority: minor Milestone:
Component: router/update Version: 0.9.4
Keywords: Cc:
Parent Tickets: Sensitive: no


If our update policy is "Download, Verify, Restart", we should start rejecting tunnels when we find one to download.

If verification fails, accept.
If verification succeeds, we can shut down sooner and we saved ourselves some time (if download takes 10 minutes at least).


Change History (3)

comment:1 Changed 8 years ago by DISABLED

Component: unspecifiedrouter/update
Milestone: 0.9.5
Type: defectenhancement

IMHO there is no benefit in doing this - an impending restart brings no change in client tunnels and ~2 minutes extra downtime will have virtually no effect on the rest of the network. So you do not save yourself any time - shutdown now vs dhutdown later both result in the same downtime.

That said, it may be worthwhile to wait until there are naturally no participating tunnels before a restart (if appropriate)

comment:2 Changed 8 years ago by zzz

Might be worth doing if it's a download initiated manually, as presumably the user will click restart when it's done. This would be independent of policy. But then we need a timer, if the user doesn't click restart after a few minutes, we start accepting tunnels again. Now it's getting complicated…

For automatic downloads, it's unattended, so no use saving time, right?

Sounds like small benefit for the effort, but please elaborate on why it's important to you.

comment:3 Changed 8 years ago by zzz

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.