Opened 6 years ago

Closed 5 years ago

#919 closed defect (fixed)

eepsite served from $INSTALL_DIR\eepsite\docroot in Windows

Reported by: killyourtv Owned by:
Priority: blocker Milestone: 0.9.6
Component: apps/jetty Version: 0.9.5
Keywords: Cc:
Parent Tickets:

Description

In Windows 7 (and 8, at least), eepsites are served from C:\program files\i2p\eepsite\docroot when run as a regular user and using the wrapper.

Subtickets

Change History (8)

comment:1 Changed 6 years ago by killyourtv

Note: this occurs with (at least) 0.9.5-0 and 0.9.5-10.

comment:2 Changed 6 years ago by zzz

  • Priority changed from major to blocker

(following to be verified - untested)

The change to build.xml on 12/24/12 to add fixcrlf, changing clients.config in the windows installer to DOS line endings, broke WorkingDir?.migrateClientsConfig() at line 296.

The line didn't get converted from "eepsite/jetty.xml" to the full path when clients.config got copied from $I2P to %appdata%\I2P\ --- so it's a relative path. It will either get served from $I2P if that's the $CWD, or it will not be found if the $CWD is somewhere else, depending on how it was started.

The fix is probably in WorkingDir? - we should handle DOS line endings on all config files.
We should audit everything else to make sure the December change didn't break anything else. The change was early in the 0.9.5 cycle but it didn't get enough testing.

Also to do - see if this breaks the Jetty 7 migration code.

Also: send out some info to people who might be looking for their eepsite base.

Thanks to PrivacyHawk? for the initial report.

comment:3 Changed 6 years ago by zzz

\r trimmed in WorkingDir? in 0.9.5-11 rev 40d650b134e48bdb0bb636227381c22217365c47

comment:4 Changed 6 years ago by zzz

see also #920 , subsequent migration to Jetty 7 will break eepsite completely.

comment:5 Changed 6 years ago by zzz

If you are running Windows and first installed I2P with version 0.9.5, see important information on manual fixes required at http://www.i2p2.de/ticket919 or http://www.i2p2.i2p/ticket919 .

This ticket is essentially fixed, but leaving open while we review all config files for other CRLF glitches. Verify that when our code rewrites files on Windows that the CRLFs remain.

comment:6 Changed 6 years ago by zzz

0.9.5-win1 released on April 21 with fixes for this ticket and #912, #920.

comment:7 Changed 5 years ago by str4d

  • Status changed from new to testing

comment:8 Changed 5 years ago by zzz

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.