Opened 6 years ago

Last modified 4 years ago

#973 open defect

Don't start threads in constructors

Reported by: zzz Owned by:
Priority: maintenance Milestone:
Component: unspecified Version: 0.9.6
Keywords: cleanup Cc: zab@…
Parent Tickets: Sensitive: no

Description

Caught by findbugs but we do it often enough to warrant its own ticket.

I'm working on i2ptunnel and I2CP cases as a part of the numerous i2ptunnel locking tickets.

I've fixed a few other places over the years.

Beware of changing behavior in any public API, that would be bad.

Subtickets

Change History (5)

comment:1 Changed 6 years ago by Zlatin Balevsky

Cc: zab@… added

+1 :)

comment:6 Changed 6 years ago by zzz

Mentioned in #946 among others.

comment:7 Changed 6 years ago by zzz

Some of these were fixed in i2ptunnel server-side work.

We're down to 5 of these according to findbugs, 4 in i2ptunnel and 1 in SAM.

The i2ptunnel client-side ones may be fixed as a part of i2ptunnel tickets #815 #650 #642, target 0.9.10.

comment:8 Changed 5 years ago by str4d

Keywords: cleanup added
Milestone: 0.9.10

comment:9 Changed 4 years ago by str4d

Status: new → open
Note: See TracTickets for help on using tickets.