Opened 6 years ago

Closed 6 years ago

#999 closed defect (fixed)

NPE in streaming

Reported by: str4d Owned by: Zlatin Balevsky
Priority: major Milestone: 0.9.8
Component: streaming Version: 0.9.7.1
Keywords: NPE Cc: Zlatin Balevsky
Parent Tickets: Sensitive: no

Description

Upgraded one of my servers to 0.9.7.1, and then found this in the logs three times (first two separated by a few minutes, the third about half an hour later).

ERROR [lRunner XXXX] .i2p.i2ptunnel.I2PTunnelRunner: Internal error

java.lang.NullPointerException?
at net.i2p.client.streaming.PacketLocal?.cancelled(PacketLocal?.java:131)
at net.i2p.client.streaming.Connection.killOutstandingPackets(Connection.java:634)
at net.i2p.client.streaming.Connection.disconnectComplete(Connection.java:623)
at net.i2p.client.streaming.I2PSocketFull.destroy(I2PSocketFull.java:149)
at net.i2p.client.streaming.I2PSocketFull.close(I2PSocketFull.java:58)
at net.i2p.i2ptunnel.I2PTunnelRunner.close(I2PTunnelRunner.java:273)
at net.i2p.i2ptunnel.I2PTunnelRunner.run(I2PTunnelRunner.java:198)

Subtickets

Change History (4)

comment:1 Changed 6 years ago by str4d

The offending method:

apps/streaming/java/src/net/i2p/client/streaming/PacketLocal.java

public void cancelled() {

synchronized (this) {

_cancelledOn = _context.clock().now();
releasePayload();
notifyAll();

}
_resendEvent.cancel(); ←————— line 131, NPE
if (_log.shouldLog(Log.DEBUG))

_log.debug("Cancelled! " + toString(), new Exception("cancelled"));

}

comment:2 Changed 6 years ago by zzz

Milestone: 0.9.8
Owner: set to Zlatin Balevsky
Priority: minormajor
Status: newassigned

Doesn't seem to be directly related to the 0.9.7 → 0.9.7.1 changes? But assigning to zab anyway as he is working on streaming atm.

comment:3 Changed 6 years ago by zzz

Version: 0.9.70.9.7.1

comment:4 Changed 6 years ago by Zlatin Balevsky

Cc: Zlatin Balevsky added
Resolution: fixed
Status: assignedclosed

Fix has been in trunk for a while now. It just didn't get "plucked" to 0.9.7.1

Note: See TracTickets for help on using tickets.